Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait logic on RollableScalableResource<Deployment> #3398

Closed
shawkins opened this issue Aug 11, 2021 · 3 comments · Fixed by #3470
Closed

wait logic on RollableScalableResource<Deployment> #3398

shawkins opened this issue Aug 11, 2021 · 3 comments · Fixed by #3470
Assignees
Milestone

Comments

@shawkins
Copy link
Contributor

shawkins commented Aug 11, 2021

If I do something like:

deployment.scale(0, true);
deployment.scale(1, true);

The second wait is only checking the replicas, not the available/unavailable replicas. Is that by design - such that I need to also do deployment.waitUntilReady or should that be handled in the scale call?

@manusa
Copy link
Member

manusa commented Sep 6, 2021

The problem now is that if we change the behavior, it might affect any user who is actually depending on the current behavior.

If used in combination with deployment#isReady, it should work as you expect, since Readiness does check for replica availability.

@manusa
Copy link
Member

manusa commented Sep 6, 2021

Methods added in #25

@shawkins
Copy link
Contributor Author

shawkins commented Sep 6, 2021

Ok, I'll add a javadoc clarifying the meaning of wait.

shawkins added a commit to shawkins/kubernetes-client that referenced this issue Sep 15, 2021
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Sep 15, 2021
@manusa manusa added this to the 5.8.0 milestone Sep 21, 2021
manusa pushed a commit that referenced this issue Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants