Builders do not preserve additionalProperties

[shawkins]

When using a builder and you use a withXXX to associate another object - under the covers the a copy is made via a constructor that omits the additional properties.

[manusa]

Is this something that needs to be fixed here or in Sundrio?

A reproducer example, or ignored test would be useful.

[shawkins]

Is this something that needs to be fixed here or in Sundrio?

I think here. There's no constructor nor setter for the building logic to use to convey the additionalProperties. If I modify Pod.java to have a setter, the the fluent / builder is updated appropriately.

[shawkins]

@manusa @iocanel or do you want an upstream issue about understanding the existing setAdditionalProperty? A possible issue with that is that it's not symmetric - there's only getAdditionalProperties,

[manusa]

A possible issue with that is that it's not symmetric - there's only getAdditionalProperties

I think jsonschema2pojo is in charge of generating the additionalProperties field and related methods (property setter, and getter).

I'm not sure if this can be tweaked to be able to add a normal setter too and prevent the problem. But if there's no option, it seems like a hard problem to tackle then.

And I think the issue is similar for the constructor.

[manusa]

We can try to implement an extra rule (jsonschema2pojo) to complement the AdditionalPropertiesRule and generate the missing setter.

We already have some custom rules to fix the naming convention (#2639)