Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Go model generation for open-cluster-management #6427

Closed
manusa opened this issue Oct 7, 2024 · 1 comment · Fixed by #6571
Closed

Replace Go model generation for open-cluster-management #6427

manusa opened this issue Oct 7, 2024 · 1 comment · Fixed by #6571
Assignees
Labels
Milestone

Comments

@manusa
Copy link
Member

manusa commented Oct 7, 2024

Description

Part of #6130

Replace model generation for open-cluster-management module with new OpenAPI approach.

Note

For extension models there are going to be multiple conflicts with the previously generated code.

Tasks

  • Remove build-helper-maven-plugin
  • Remove maven-antrun-plugin from the generate profile
  • Remove jsonschema2pojo-maven-plugin from the generate profile
  • Consolidate all extension models to the same module (certmanager, tekton, and so on all have multiple model generator modules)
  • Configure the openapi-model-generator-maven-plugin plugin to generate the specific classes.
  • Remove the go-related files and directories (Makefile, cmd)
  • Remove invocation from the generateModel.sh script
@manusa
Copy link
Member Author

manusa commented Oct 10, 2024

Models:
https://docs.redhat.com/en/documentation/red_hat_advanced_cluster_management_for_kubernetes/2.3/html/apis/apis#rhacm-docs_apis_cluster_jsondeletecluster
#3506 (comment)

Group URL
agent.open-cluster-management.io https://github.com/stolostron/klusterlet-addon-controller/tree/main/pkg/apis/agent/v1
app.k8s.io https://github.com/kubernetes-sigs/application/tree/master/api/v1beta1 extremely deprecated
apps.open-cluster-management.io - https://github.com/open-cluster-management-io/multicloud-operators-channel/tree/main/pkg/apis/apps/v1
- https://github.com/open-cluster-management-io/multicloud-operators-subscription/tree/main/pkg/apis/apps/v1
- https://github.com/stolostron/multicloud-operators-placementrule/tree/main/pkg/apis/apps extremely deprecated
- https://github.com/stolostron/multicloud-integrations/tree/main/pkg/apis/apps extremely deprecated
cluster.open-cluster-management.io https://github.com/open-cluster-management-io/api/tree/main/cluster
discovery.open-cluster-management.io https://github.com/stolostron/discovery/blob/main/api/
observability.open-cluster-management.io https://github.com/stolostron/multicluster-observability-operator/tree/main/operators/multiclusterobservability/api
operator.open-cluster-management.io - https://github.com/stolostron/multiclusterhub-operator/tree/main/api/v1
- https://github.com/open-cluster-management-io/api/tree/main/operator/v1
policy.open-cluster-management.io https://github.com/stolostron/governance-policy-propagator/tree/main/api
search.open-cluster-management.io - https://github.com/stolostron/search-operator/tree/main/api/v1alpha1 extremely deprecated
- https://github.com/stolostron/search-v2-operator

@manusa manusa assigned manusa and unassigned manusa Oct 10, 2024
@manusa manusa self-assigned this Nov 12, 2024
@manusa manusa added this to the 7.0.0 milestone Nov 13, 2024 — with automated-tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant