Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to extend model to cover ACM #3506

Closed
AbrahamArellano opened this issue Oct 1, 2021 · 3 comments · Fixed by #3641
Closed

Request to extend model to cover ACM #3506

AbrahamArellano opened this issue Oct 1, 2021 · 3 comments · Fixed by #3641
Assignees
Milestone

Comments

@AbrahamArellano
Copy link

Hi team,

I would like to request the extension of the model to cover also Advanced Cluster Management. Currently our team is using the library in order to deploy clusters with ACM and it was required to extend the model to some of the following objects:

  • ClusterDeployment
  • ClusterDeploymentControlPlaneConfig
  • ClusterDeploymentPlatform
  • InstallConfig
  • ManagedCluster
  • etc.

In addition, would it be ideal to take advantage of the different functions available out of the box by RHACM as Java methods:
https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.3/html-single/apis/index#rhacm-docs_apis_cluster_jsoncreatecluster

Thanks

@rohanKanojia
Copy link
Member

rohanKanojia commented Dec 2, 2021

@AbrahamArellano : The resource URL doesn't look like it follows standard Kubernetes API (/apis/{group}/{version}/{plural}) convention:

create()        POST /apis/cluster.open-cluster-management.io/v1/managedclusters
get()           GET /apis/cluster.open-cluster-management.io/v1/managedclusters/{cluster_name}
list()          GET /apis/cluster.open-cluster-management.io/v1alpha1/managedclustersets
delete()        DELETE /apis/cluster.open-cluster-management.io/v1/managedclusters/{cluster_name}

Are the abovementioned objects custom resources? I installed Cluster manager and klusterlet on my OpenShift cluster but these were the only additional resources in operator.open-cluster-management.io/v1 apigroup:

kubernetes-client : $ kubectl api-resources | grep open-cluster
clustermanagers                                        operator.open-cluster-management.io/v1        false        ClusterManager
klusterlets                                            operator.open-cluster-management.io/v1        false        Klusterlet

@rohanKanojia rohanKanojia self-assigned this Dec 6, 2021
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 8, 2021
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 9, 2021
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 9, 2021
@AbrahamArellano
Copy link
Author

Hi @rohanKanojia , the challenge here is to use the library to operate with the ACM API, and in order to create managed clusters, delete them and so on, we need the capabilities to create those entities in OpenShift.
For that the ACM API describes the objects we would need.
https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.3/html-single/apis/index#rhacm-docs_apis_cluster_jsoncreatecluster

rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 10, 2021
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 10, 2021
@rohanKanojia
Copy link
Member

@AbrahamArellano : Thanks for your reply. I have created a draft PR(#3641) for Open Cluster Management extension which provides support for the following resources provided in https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.3/html/apis/apis

  • ManagedCluster cluster.open-cluster-management.io/v1
  • ManagedClusterSet cluster.open-cluster-management.io/v1beta1
  • ManagedClusterSetBinding cluster.open-cluster-management.io/v1beta1
  • Channel apps.open-cluster-management.io/v1
  • Subscription apps.open-cluster-management.io/v1
  • PlacementRule apps.open-cluster-management.io/v1
  • Application app.k8s.io/v1beta1
  • HelmRelease apps.open-cluster-management.io/v1
  • Policy policy.open-cluster-management.io/v1
  • MultiClusterObservability observability.open-cluster-management.io/v1beta2
  • SearchCustomization search.open-cluster-management.io/v1alpha1
  • MultiClusterHub operator.open-cluster-management.io/v1
  • Placements API cluster.open-cluster-management.io/v1alpha1
  • PlacementDecisions API cluster.open-cluster-management.io/v1alpha1
  • DiscoveryConfig discovery.open-cluster-management.io/v1alpha1
  • DiscoveredCluster discovery.open-cluster-management.io/v1alpha1

Would appreciate if you could find time to try it out and provide feedback if there is something that needs to be added.

rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 10, 2021
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 10, 2021
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 10, 2021
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 13, 2021
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 29, 2021
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Dec 30, 2021
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Jan 12, 2022
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Jan 21, 2022
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Jan 21, 2022
manusa pushed a commit that referenced this issue Jan 24, 2022
@manusa manusa added this to the 5.12.0 milestone Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants