Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: support loading from kubeconfig string #1029

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

colemickens
Copy link

Fixes #1028.

I've manually verified this by building the kubernetes-plugin for Jenkins with my modified library and was able to connect to a cluster via a kubeconfig provided as a secretText by utilizing the fromKubeconfig static method added here.

My intent was to reduce code duplication, while still preserving the existing code path with tryKubeConfig and with the relative->absolute path rewriting in kubeconfig.

@rohanKanojia
Copy link
Member

ok to test

@oscerd
Copy link
Member

oscerd commented Mar 13, 2018

ok to test

@piyush-garg
Copy link
Contributor

@colemickens Can you please add the changes to CHANGELOG.md

@colemickens
Copy link
Author

@piyush1594 I have pushed a new commit with an updated CHANGELOG.md.

@oscerd
Copy link
Member

oscerd commented Mar 13, 2018

[merge]

@fusesource-ci fusesource-ci merged commit eab9713 into fabric8io:master Mar 13, 2018
@colemickens
Copy link
Author

Sorry to ask, but is there any guidance on when releases are cut? I see that it's been almost 3 months since the last release. I'm anxious to use this new functionality in a release package.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants