Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes around exceptional cases in watchers #2671

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Fixes around exceptional cases in watchers #2671

merged 3 commits into from
Dec 17, 2020

Commits on Dec 16, 2020

  1. Fixes around exceptional cases in watchers: 

    - If the target of a watch is deleted, it will never satisfy the watch condition
- Path segment based filters have spotty support in newer kube api versions. Field selector seems to work everywhere
- Handle unsuccessful watch statuses better -- we should either be retrying, or passing an error event back to the user. Throwing an exception will result in a transparent failure that no user can handle, because it happens in a thread
- long polls return a response once data is available. we should only backoff in exceptional cases, otherwise immediately connect so we can receive followup data in a more timely manner
    @bbeaudreault
    bbeaudreault committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    6d68a3d View commit details
    Browse the repository at this point in the history

  2. changelog

    @bbeaudreault
    bbeaudreault committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    3c52416 View commit details
    Browse the repository at this point in the history

  3. fix test

    @bbeaudreault
    bbeaudreault committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    283716d View commit details
    Browse the repository at this point in the history