Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set no_proxy in the okhttp builder in case the proxy_url is null #3000

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

jkhelil
Copy link
Contributor

@jkhelil jkhelil commented Apr 15, 2021

Description

When the proxy properties are set (http.proxy, no.proxy...) and the master host should not go through the proxy, okhttp is still tunneling over the proxy, we should disable the proxy in case where the master url should not go through the proxy
it is working also when the proxy.url is not found

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

@sonarcloud
Copy link

sonarcloud bot commented Apr 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa
Copy link
Member

manusa commented Apr 16, 2021

Hi @jkhelil,
@rohanKanojia mentioned you needed this in 4.13, is it right?

@jkhelil
Copy link
Contributor Author

jkhelil commented Apr 16, 2021

Hi @manusa we need a backport for v4.13.2 please

@manusa manusa added this to the 4.13.3 milestone Apr 16, 2021
@manusa manusa merged commit 891c3be into fabric8io:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants