Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2912: Add DSL Support for storage.k8s.io/v1beta1 CSIStorageCapacity #3010

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Fix #2912: Add DSL Support for storage.k8s.io/v1beta1 CSIStorageCapacity #3010

merged 1 commit into from
Apr 19, 2021

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Apr 19, 2021 •
edited
Loading

Description

I noticed this when I upgraded my minikube to v1.21.0 and noticed there is an additional resource in storage.k8s.io/v1beta1

This should fix #2912

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

manusa
manusa approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@manusa manusa merged commit dcad242 into fabric8io:master Apr 19, 2021
@manusa manusa mentioned this pull request Apr 20, 2021
Closed
manusa added a commit to marcnuri-demo/fabric8-kubernetes-client-jbang that referenced this pull request Apr 23, 2021
@manusa
feat: Validation for fabric8io/kubernetes-client#3010
9ac9acc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide DSL support for All Kubernetes resources
3 participants
@rohanKanojia @manusa @oscerd