Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump sundrio to 0.40.1 #3118

Merged
merged 5 commits into from
May 19, 2021
Merged

Bump sundrio to 0.40.1 #3118

merged 5 commits into from
May 19, 2021

Conversation

iocanel
Copy link
Member

@iocanel iocanel commented May 14, 2021

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

@manusa
Copy link
Member

manusa commented May 14, 2021

Could you rebase on current master? Most changes were probably covered by #3114 which was already merged

@manusa manusa mentioned this pull request May 14, 2021
Closed
@iocanel iocanel force-pushed the sundrio-0.40.0 branch 3 times, most recently from 790bd0b to f2fa0b9 Compare May 18, 2021 07:54
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

34.2% 34.2% Coverage
49.9% 49.9% Duplication

manusa
manusa approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 76e1762 into fabric8io:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iocanel @centos-ci @manusa @oscerd @rohanKanojia