Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing resources in operator.openshift.io and monitoring.coreos.com apiGroups in OpenShiftClient DSL #3142

Merged
merged 1 commit into from
May 25, 2021

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented May 18, 2021

Description

Add missing resources in OpenShiftClient DSL for the following:

operator.openshift.io

  • CloudCredential openShiftClient.operator().cloudCredentials()
  • ClusterCSIDriver openShiftClient.operator().clusterCSIDrivers()
  • Config openShiftClient.operator().configs()
  • PodNetworkConnectivityCheck openShiftClient.operator().podNetworkConnectivityChecks()
  • Storage openShiftClient.operator().storages()

monitoring.coreos.com

  • AlertmanagerConfig openShiftClient.monitoring().alertmanagerConfigs()
  • Probe openShiftClient.monitoring().probes()
  • ThanosRuler openShiftClient.monitoring().thanosRulers()

Related to #2949

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other dXcumentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia changed the title Add missing resources in operator.openshift.io and monitoring.coreos.com Add missing resources in operator.openshift.io and monitoring.coreos.com apiGroups in OpenShiftClient DSL May 18, 2021
@rohanKanojia rohanKanojia marked this pull request as ready for review May 19, 2021 06:28
@manusa manusa force-pushed the pr/openshift-model-operator branch from fb265a6 to 42b64fd Compare May 20, 2021 05:23
Add missing resources in OpenShiftClient DSL for the following:

operator.openshift.io
- CloudCredential `openShiftClient.operator().cloudCredentials()`
- ClusterCSIDriver `openShiftClient.operator().clusterCSIDrivers()`
- Config `openShiftClient.operator().configs()`
- PodNetworkConnectivityCheck `openShiftClient.operator().podNetworkConnectivityChecks()`
- Storage `openShiftClient.operator().storages()`

monitoring.coreos.com
- AlertmanagerConfig `openShiftClient.monitoring().alertmanagerConfigs()`
- Probe `openShiftClient.monitoring().probes()`
- ThanosRuler `openShiftClient.monitoring().thanosRulers()`

Related to fabric8io#2949
@manusa manusa force-pushed the pr/openshift-model-operator branch from 42b64fd to e006a01 Compare May 20, 2021 12:37
@sonarcloud
Copy link

sonarcloud bot commented May 20, 2021

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 6932324 into fabric8io:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants