Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using a strategic merge to prevent a 422 #3148

Merged
merged 2 commits into from
May 26, 2021
Merged

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented May 20, 2021

Description

Addressing the integration test timing issue seen in #3136 (comment) with a strategic merge patch.

@rohanKanojia it feels a little verbose to create a patch context of a given patch type - should there be utility methods for that?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

@rohanKanojia
Copy link
Member

sure, I think we can add some utility methods for PatchContext (maybe in KubernetesResourceUtil). Do you have some idea in mind with which we can improve readability?

@shawkins
Copy link
Contributor Author

how about - PatchContext.of(patchType)

@rohanKanojia
Copy link
Member

Sounds good to me.

@sonarcloud
Copy link

sonarcloud bot commented May 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@shawkins
Copy link
Contributor Author

@manusa https://github.com/fabric8io/kubernetes-client/pull/3148/files#diff-0ae0c25ccaf88d84f2fc51e6487f7033e312ca550ce5af75ace50bdc3a75168fR90 is now the clearest expression of what you were looking for in #3078 (comment)

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit d1ab437 into fabric8io:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants