-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using a strategic merge to prevent a 422 #3148
Conversation
Can one of the admins verify this patch? |
sure, I think we can add some utility methods for PatchContext (maybe in KubernetesResourceUtil). Do you have some idea in mind with which we can improve readability? |
how about - PatchContext.of(patchType) |
Sounds good to me. |
Kudos, SonarCloud Quality Gate passed! |
@manusa https://github.com/fabric8io/kubernetes-client/pull/3148/files#diff-0ae0c25ccaf88d84f2fc51e6487f7033e312ca550ce5af75ace50bdc3a75168fR90 is now the clearest expression of what you were looking for in #3078 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Description
Addressing the integration test timing issue seen in #3136 (comment) with a strategic merge patch.
@rohanKanojia it feels a little verbose to create a patch context of a given patch type - should there be utility methods for that?
Type of change
test, version modification, documentation, etc.)
Checklist