Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for OpenShift MachineConfig Operator Model(machineconfiguration.openshift.io) in OpenShiftClient DSL #3166

Merged

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented May 24, 2021

Description

Add Model+DSL Support for OpenShift MachineConfig Operator Model
resources in OpenShiftClient DSL. Introduced a DSL entrypoint called
openshiftClient.machineConfigurations() which would provide all
available resources

  • ContainerRuntimeConfig client.machineConfigurations().containerRuntimeConfigs()
  • ControllerConfig client.machineConfigurations().controllerConfigs()
  • KubeletConfig client.machineConfigurations().kubeletConfigs()
  • MachineConfigPool client.machineConfigurations().machineConfigPools()
  • MachineConfig client.machineConfigurations().machineConfigs()

Related to #2949

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia marked this pull request as ready for review May 25, 2021 09:43
Add Model+DSL Support for OpenShift MachineConfig Operator Model
resources in OpenShiftClient DSL. Introduced a DSL entrypoint called
`openshiftClient.machineConfigurations()` which would provide all
available resources

Related to fabric8io#2949
@rohanKanojia rohanKanojia force-pushed the pr/openshift-model-machineconfig branch from 3e92ef2 to 224190e Compare May 26, 2021 06:31
@sonarcloud
Copy link

sonarcloud bot commented May 26, 2021

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 646384f into fabric8io:master May 26, 2021
@manusa manusa added this to the 5.5.0 milestone Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants