Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring to remove some of the code around pumpers #3169

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented May 25, 2021

Description

I don't know if this is desirable, but with the other changes related to threading concerns the pumper classes and calls to utils.shutdownExecutorService seemed suspect. This change tries to separate out the various responsibilities of the pumpers to just a couple of static calls. I am not sure however if clients are using these classes (InputStreamPumper, Callback) as they ended up in the examples as well.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I really like where this is going.
I added some comments/questions though about some things I would like to better understand.

@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2021

@iocanel iocanel self-requested a review June 16, 2021 13:53
Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 5bfcac2 into fabric8io:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants