Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use File.toURI() to create the generated crd uri. #3172

Merged
merged 1 commit into from
May 26, 2021

Conversation

iocanel
Copy link
Member

@iocanel iocanel commented May 26, 2021

This is meant to fix the issue with the malformed URI on windows.

The fix has not been verified manually, but usually this short of issues are handled better when you delegate to java itself.

@centos-ci
Copy link

Can one of the admins verify this patch?

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 5.5.0 milestone May 26, 2021
@manusa manusa added the changelog missing A line to changelog.md regarding the change is not added label May 26, 2021
@manusa manusa merged commit 251d724 into fabric8io:master May 26, 2021
@manusa manusa modified the milestones: 5.5.0, 5.4.1 May 31, 2021
@manusa manusa removed the changelog missing A line to changelog.md regarding the change is not added label Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants