fix: handling of JsonProperty when generating crds. #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
oscerd
approved these changes
May 27, 2021
manusa
reviewed
May 27, 2021
crd-generator/api/src/main/java/io/fabric8/crd/generator/AbstractJsonSchema.java
Outdated
Show resolved
Hide resolved
metacosm
reviewed
May 27, 2021
crd-generator/api/src/main/java/io/fabric8/crd/generator/AbstractJsonSchema.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
manusa
approved these changes
May 31, 2021
manusa
added
the
changelog missing
manusa
pushed a commit
that referenced
this pull request
May 31, 2021
* fix: handling of JsonProperty when generating crds. * fix: use logger instead of System.out * fix: properly handle property renaming from JsonProperty, add tests Co-authored-by: Chris Laprun <[email protected]> (cherry picked from commit 7bbc02c)
manusa
removed
the
changelog missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with when generating schema for items annotated with the
JsonProertyannotation.