Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for autoscaling.openshift.io resources in OpenShiftClient #3193

Merged

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented May 31, 2021

Description

  • Add new module openshift-model-clusterautoscaling in
    kubernetes-model-generator
  • Add DSL support for these resources:
    • MachineAutoscaler openShiftClient.clusterAutoscaling().v1beta1().machineAutoscalers()
    • ClusterAutoscaler openShiftClient.clusterAutoscaling().v1().clusterAutoscalers()

Related to #2949

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

+ Add new module openshift-model-clusterautoscaling in
  kubernetes-model-generator
+ Add DSL support for these resources:
    - MachineAutoscaler `openShiftClient.clusterAutoscaling().v1beta1().machineAutoscalers()`
    - ClusterAutoscaler `openShiftClient.clusterAutoscaling().v1().clusterAutoscalers()`

Related to fabric8io#2949
@manusa manusa force-pushed the pr/openshift-model-autoscaling branch from af0a72a to fc28f72 Compare June 2, 2021 15:01
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2021

@manusa manusa merged commit 464b1ff into fabric8io:master Jun 2, 2021
@manusa manusa added this to the 5.5.0 milestone Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants