Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3189: VersionInfo contains null data in OpenShift 4.x #3198

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Fix #3189: VersionInfo contains null data in OpenShift 4.x #3198

merged 1 commit into from
Jun 1, 2021

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jun 1, 2021 •
edited by manusa
Loading

Description

Fix #3189

assert response code after getting response from apiServer rather than
depending upon fragile null check.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

manusa
manusa approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa added this to the 5.4.1 milestone Jun 1, 2021
@rohanKanojia
Fix fabric8io#3189: VersionInfo contains null data in OpenShift 4.x
3f017ec 
assert response code after getting response from apiServer rather than
depending upon fragile null check
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 062313c into fabric8io:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.4.1
Development

Successfully merging this pull request may close these issues.

VersionInfo contains null data in OpenShift 4.6
3 participants
@rohanKanojia @manusa @oscerd