Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tuned.openshift.io apiGroup in OpenShiftClient DSL #3201

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jun 1, 2021

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia changed the title Add support for tuned.openshift.io apiGroup in OpenShiftClient DSL Add support for tuned.openshift.io apiGroup in OpenShiftClient DSL Jun 1, 2021
@rohanKanojia rohanKanojia marked this pull request as ready for review June 3, 2021 11:25
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

+ Add new module `openshift-model-tuned/` for OpenShift Note Tuning operator model
+ Add new DSL entrypoint `openShiftClient.tuned()` in OpenShiftClient DSL
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2021

@manusa manusa merged commit d810aa1 into fabric8io:master Jun 3, 2021
@manusa manusa added this to the 5.5.0 milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants