-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #3294 #3303 exposing apigroups and apiresource #3405
Conversation
Can one of the admins verify this patch? |
This adds methods to the Client interface for the api resource and group information. Alternatives include introducing a Client.metadata() call and associated container api, but something like that hasn't been mentioned anywhere so it doesn't seem necessary. |
I'll address the openshift test next time I have a cluster up to test against. The compile errors though don't make sense to me. |
kubernetes-client/src/main/java/io/fabric8/kubernetes/client/Client.java
Show resolved
Hide resolved
@shawkins : I'm not sure you're aware of this but you can easily get a free OpenShift Cluster with Red Hat Developer Sandbox[0]. I usually test OpenShift related stuff and it works okay.
I'm not able to reproduce these errors as well. |
Looks like I made a simple mistake in the isAdaptable method. I've pushed a correction along with getting a single api group. |
@rohanKanojia the remaining exception is related to https://github.com/fabric8io/kubernetes-client/pull/3405/files#diff-32314261b10bfe7703677b8086d5a28ff2dd1d0a8dc1061cdaad58e22c091576L84 I've changed things to no longer swallow the exception - the mock server is not responding to /apis. Was the old code intentionally swallowing the exception or should I look at adding mock server support for this as well? |
I think I did a mistake by swallowing the exception. |
@rohanKanojia I think things are good now. There was another boolean that needed flipped. The build still seems to be hitting those weird compile errors. |
@manusa rebased and still behaving oddly. |
Fixed in #3487 |
Description
Adds client methods for apigroups and apiresources. Also consolidates existing logic about openshift adapting.
Type of change
test, version modification, documentation, etc.)
Checklist