Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3460: support for deserializing templates with non-string params #3526

Merged
merged 2 commits into from
Nov 3, 2021
Merged

fix #3460: support for deserializing templates with non-string params #3526

merged 2 commits into from
Nov 3, 2021

Conversation

shawkins
Copy link
Contributor

Description

Took another look at the template deserialization issue and thought it would be worth proposing this solution - there does not seem to be a great way to trap this error using other jackson mechanisms.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins added the wip label Oct 11, 2021
@shawkins shawkins requested a review from manusa October 11, 2021 18:52
@centos-ci
Copy link

Can one of the admins verify this patch?

@shawkins shawkins linked an issue Oct 12, 2021 that may be closed by this pull request
Loading a template with an Integer parameter value fails deserialisation #448
Closed
@shawkins shawkins removed the wip label Oct 13, 2021
@manusa
Copy link
Member

manusa commented Oct 19, 2021

Relates to #3460

@manusa manusa added this to the 5.10.0 milestone Nov 3, 2021
manusa
manusa approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa added the changelog missing A line to changelog.md regarding the change is not added label Nov 3, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

36.8% 36.8% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 51475cd into fabric8io:master Nov 3, 2021
@manusa manusa mentioned this pull request Nov 8, 2021
Merged
11 tasks
@manusa manusa removed the changelog missing A line to changelog.md regarding the change is not added label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.10.0
Development

Successfully merging this pull request may close these issues.

Loading a template with an Integer parameter value fails deserialisation
3 participants
@shawkins @centos-ci @manusa