MockWebServer bump, refactor and enhancements

[manusa]

Description

• deps: bump mockwebserver
• Removed usage of deprecated methods
• Introduced KubernetesMixedDispatcher, allows using CRUD mode and expectation mode simultaneously
• Replaced usaged of KubernetesCrudDispatcher with KubernetesMixedDispatcher
• Added default expectation for /version (fix KubernetesServerMock CRUD mode doesn't provide valid responses for client.getXxxxVersion #3536)

The new KubernetesMixedDispatcher allows the user to create expectations on top of the default CRUD KubernetesMockServer behavior. This way non-resource endpoints (such as /version), can be mocked while the rest of the CRUD features are preserved (/cc @metacosm)

With the current approach, a user still needs to create a manual expectation for the version endpoint:

    server.expect().get().withPath("/version")
      .andReturn(200, "{\"major\": \"13\", \"minor\": \"37\"}").always();

This can be further improved if we add a hardcoded expectation here:

kubernetes-client/kubernetes-server-mock/src/main/java/io/fabric8/kubernetes/client/server/mock/KubernetesMockServer.java

Line 65 in ace88b1

expect().get().withPath("/").andReturn(200, new RootPathsBuilder().addToPaths(getRootPaths()).build()).always();

But I'm not sure if that would bother the rest of users.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I Added CHANGELOG entry regarding this change
• I have implemented unit tests to cover my changes
• I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[centos-ci]

Can one of the admins verify this patch?

[metacosm]

This seems to indeed fix the issue when you get direct access to the KubernetesMockServer. When using Quarkus, though, you don't always get direct access, in particular when using the QuarkusTestResource annotation, so it's a little annoying to have to create a specific extension of KubernetesServerTestResource just to be able to set up the version endpoint for example, so it'd indeed be nice if we could have some hardcoded expectations to make things easier.

[manusa]

so it'd indeed be nice if we could have some hardcoded expectations to make things easier.

It seems it shouldn't do any harm, so I finally added the hardcoded expectation for the version endpoint

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

47.6% Coverage
0.0% Duplication