Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refining #3559 - allows the connect and websocket timeouts to apply to watches instead of hardcoded timeout #3674

Merged
merged 1 commit into from
Jan 3, 2022
Merged

refining #3559 - allows the connect and websocket timeouts to apply to watches instead of hardcoded timeout #3674

merged 1 commit into from
Jan 3, 2022

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Dec 22, 2021 •
edited by manusa
Loading

Description

Supersedes closes #3559

A replacement for #3559 post okhttp refactoring. There were a couple of refinements to make sure that timeout exceptions bubble up as expected. With this change the connect and websocket (which defaults to the smallest amount of time) timeouts are enforced during waitUntilReady.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

@shawkins
Copy link
Contributor Author

I did not see a good way to unit test this as the delay logic in the mock server does not seem to work.

@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

31.2% 31.2% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 5.12.0 milestone Dec 24, 2021
manusa
manusa approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit dc0e25f into fabric8io:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shawkins @centos-ci @manusa @rohanKanojia