Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4491: adding a more explicit shutdown exception #4500

Merged
merged 1 commit into from
Nov 4, 2022
Merged

fix #4491: adding a more explicit shutdown exception #4500

merged 1 commit into from
Nov 4, 2022

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Oct 14, 2022 •
edited by manusa
Loading

Description

Fixes #4491 - since this has come up a couple of times we probably need a more explicit message for a RejectedExecutionException from down in okhttp. Assuming #4430 is committed, this change only needs applied to a single okhttp method.

It's also possible to handle this more generally with a proxied httpclient with close checking, but I don't think that is needed as the other clients either already do that check or provide a better exception.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa added this to the 6.3.0 milestone Nov 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit f3e776b into fabric8io:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@manusa manusa manusa approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

RejectedExecutionException when checking status of removed operator through BaseOperation.get
3 participants
@shawkins @manusa @oscerd