Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: MockWebServer based on Vert.x #5632

Closed
wants to merge 2 commits into from

Conversation

manusa
Copy link
Member

@manusa manusa commented Dec 4, 2023

Description

WIP Still working on this, but it seems that there is a viable solution with not that many breaking changes. However, it seems reasonable that this will deserve a major version change, or some tooling to help users upgrade.

Replaces the io.fabric8:mockwebserver module backend from OkHTTP to Vert.x.

Relates to:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa added the wip label Dec 4, 2023
@manusa manusa self-assigned this Dec 4, 2023
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 2 times, most recently from 7f96c77 to 492d898 Compare December 4, 2023 14:01
@rohanKanojia
Copy link
Member

Build seems to be failing because tests haven't been updated to remove okhttp mockwebserver references

@manusa
Copy link
Member Author

manusa commented Dec 12, 2023

Build seems to be failing because tests haven't been updated to remove okhttp mockwebserver references

Maybe it wasn't clear by the description, but this is just WIP.
So far only the mockwebserver module has been changed. I still need to migrate some of the tests there to use a different HTTP client instead of OkHttp. The core ones have already been updated and prove that the Mock server preserves the behavior after removing OkHttp.

Once I finish with the initial module I'll start by sending a PR to update the tests from OkHttp to Vert.x while still preserving the OkHttp production code. This way, subsequent PRs will be easier to review since tests won't (shouldn't) need updating.

@manusa manusa mentioned this pull request Dec 12, 2023
11 tasks
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 5 times, most recently from 006ddb1 to 402c179 Compare December 22, 2023 14:02
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 3 times, most recently from d44ed9c to 79026a2 Compare December 22, 2023 17:51
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 6 times, most recently from a2c396f to 212847c Compare January 4, 2024 11:09
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 4 times, most recently from 5694ce6 to 6796925 Compare August 29, 2024 13:06
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 2 times, most recently from 1074e00 to 84ad179 Compare September 11, 2024 09:41
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 2 times, most recently from 74b43da to c78f88a Compare September 17, 2024 16:15
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 2 times, most recently from 448c119 to de4c859 Compare September 24, 2024 13:29
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 6 times, most recently from 1bfd323 to cd85c6e Compare October 15, 2024 12:33
@manusa manusa force-pushed the feat/mockwebserver-vertx branch 4 times, most recently from 54c99a5 to 8d4262d Compare October 18, 2024 10:14
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@manusa manusa closed this in #6469 Oct 21, 2024
@manusa manusa deleted the feat/mockwebserver-vertx branch October 21, 2024 11:07
@manusa manusa removed the wip label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants