-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC: MockWebServer based on Vert.x #5632
Conversation
7f96c77
to
492d898
Compare
Build seems to be failing because tests haven't been updated to remove okhttp mockwebserver references |
Maybe it wasn't clear by the description, but this is just WIP. Once I finish with the initial module I'll start by sending a PR to update the tests from OkHttp to Vert.x while still preserving the OkHttp production code. This way, subsequent PRs will be easier to review since tests won't (shouldn't) need updating. |
492d898
to
c28e555
Compare
c28e555
to
54af263
Compare
006ddb1
to
402c179
Compare
d44ed9c
to
79026a2
Compare
79026a2
to
dbd1971
Compare
a2c396f
to
212847c
Compare
5694ce6
to
6796925
Compare
1074e00
to
84ad179
Compare
74b43da
to
c78f88a
Compare
448c119
to
de4c859
Compare
1bfd323
to
cd85c6e
Compare
54c99a5
to
8d4262d
Compare
Signed-off-by: Marc Nuri <[email protected]>
…rver Signed-off-by: Marc Nuri <[email protected]>
8d4262d
to
e567ace
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Description
WIP Still working on this, but it seems that there is a viable solution with not that many breaking changes. However, it seems reasonable that this will deserve a major version change, or some tooling to help users upgrade.
Replaces the
io.fabric8:mockwebserver
module backend from OkHTTP to Vert.x.Relates to:
Type of change
test, version modification, documentation, etc.)
Checklist