feat: owner reference validity check regarding scope and namespace

CHANGELOG.md

@@ -5,6 +5,7 @@
 #### Bugs
 
 #### Improvements
+* Fix #5701: Owner reference validity check regarding scope and namespace
 
 #### Dependency Upgrade
 

kubernetes-model-generator/kubernetes-model-core/src/main/java/io/fabric8/kubernetes/api/model/HasMetadata.java

@@ -358,6 +358,23 @@ default OwnerReference addOwnerReference(HasMetadata owner) {
           + getKind());
     }
 
+    if (!(owner instanceof GenericKubernetesResource)
+        && !(this instanceof GenericKubernetesResource)
+        && owner instanceof Namespaced) {
+      if (!(this instanceof Namespaced)) {
+        throw new IllegalArgumentException(
+            "Cannot add owner reference from a cluster scoped to a namespace scoped resource: "
+                + optionalMetadata().map(m -> "'" + m.getName() + "' ").orElse("unnamed ")
+                + getKind());
+      } else if (optionalMetadata().map(m -> !Objects.equals(m.getNamespace(), owner.getMetadata().getNamespace()))
+          .orElse(false)) {
+        throw new IllegalArgumentException(
+            "Cannot add owner reference between two resources in different namespaces:"
+                + optionalMetadata().map(m -> "'" + m.getName() + "' ").orElse("unnamed ")
+                + getKind());
+      }
+    }
+
     final OwnerReference ownerReference = new OwnerReferenceBuilder()
         .withUid(metadata.getUid())
         .withApiVersion(owner.getApiVersion())

kubernetes-model-generator/kubernetes-model-core/src/test/java/io/fabric8/kubernetes/api/model/HasMetadataTest.java

@@ -217,6 +217,24 @@ void addingSameOwnerReferenceMultipleTimesShouldAddItOnlyOnce() {
     assertEquals(1, hasMetadata.getMetadata().getOwnerReferences().size());
   }
 
+  @Test
+  void addingOwnerReferenceToNamespacedResourceFromClusterScopedResourceShouldFail() {
+    HasMetadata clusterScoped = new Owner();
+    HasMetadata namespaced = new OwnerNamespaced();
+
+    assertThrows(IllegalArgumentException.class, () -> clusterScoped.addOwnerReference(namespaced));
+  }
+
+  @Test
+  void addingOwnerReferenceToResourceInDifferentNamespaceShouldFail() {
+    HasMetadata namespaced1 = new OwnerNamespaced();
+    namespaced1.getMetadata().setNamespace("namespace1");
+    HasMetadata namespaced2 = new OwnerNamespaced();
+    namespaced2.getMetadata().setNamespace("namespace2");
+
+    assertThrows(IllegalArgumentException.class, () -> namespaced1.addOwnerReference(namespaced2));
+  }
+
   @Group("fabric8.io")
   @Version("v1")
   private static class Woman implements HasMetadata {
@@ -346,4 +364,8 @@ public void setApiVersion(String version) {
       throw new RuntimeException("setApiVersion shouldn't be called");
     }
   }
+
+  private static class OwnerNamespaced extends Owner implements Namespaced {
+  }
+
 }