Fix #5847: missing Log4j Core plugin descriptor #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
added a commit
to ppkarwasz/kubernetes-client
that referenced
this pull request
Mar 31, 2024
oscerd
approved these changes
Mar 31, 2024
ppkarwasz
requested review from
manusa,
rohanKanojia,
shawkins and
sunix
as code owners
rohanKanojia
approved these changes
Apr 1, 2024
Due to a misconfiguration of the Maven Bundle Plugin, the Log4j Core plugin descriptor: ``` META-INF/org/apache/logging/log4j/core/config/plugins/Log4j2Plugins.dat ``` file is missing in the generated JAR. This PR fixes the Maven configuration and adds a simple integration test to prevent ensure that `PluginManager` is able to detect the Kubernetes Lookup.
manusa
force-pushed
the
fix/missing-log4j-descriptor
branch
from
5274bb2
to
19974ff
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #5847
Due to a misconfiguration of the Maven Bundle Plugin, the Log4j Core plugin descriptor:
file is missing in the generated JAR.
This PR fixes the Maven configuration and adds a simple integration test to prevent ensure that
PluginManageris able to detect the Kubernetes Lookup.Type of change
test, version modification, documentation, etc.)
Checklist