Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: openshift-model-installer generated from OpenAPI schemas #6413

Merged
merged 1 commit into from
Oct 3, 2024
Merged

refactor: openshift-model-installer generated from OpenAPI schemas #6413

merged 1 commit into from
Oct 3, 2024

Conversation

manusa
Copy link
Member

@manusa manusa commented Oct 3, 2024

Description

Fixes: #6266

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa manusa force-pushed the refactor/openshift-model-installer branch from 92f7bac to c6f4cf2 Compare October 3, 2024 14:06
@manusa manusa added this to the 7.0.0 milestone Oct 3, 2024 — with automated-tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@manusa manusa merged commit 63766b5 into fabric8io:main Oct 3, 2024
21 checks passed
@manusa manusa deleted the refactor/openshift-model-installer branch October 3, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia rohanKanojia is a code owner

@shawkins shawkins Awaiting requested review from shawkins shawkins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Replace Go model generation for openshift-model-installer
2 participants
@manusa @oscerd