Mouseup events are duplicated in case preserveObjectStacking is ON

[solomax]

Version

1.7.17

Test Case

https://jsfiddle.net/solomax666/r2nuv845/

Steps to reproduce

1. run the fiddle
2. push 'Start' button on video
3. push 'Pause' button on video

Expected Behavior

Video should pause

Actual Behavior

Video continue playing

With debugger I find out on mouseup is being called twice due to mouseup target gets duplicated. This is not the case when preserveObjectStacking is OFF (line 2 of fiddle is commented out)

[asturur]

i see the bug in findTarget.
Before i get mad reading all your fiddle, can you explain me how the things are grouped in your use case:

Video + controls are a group?

[solomax]

There are 2 groups:
One is Play button: circle, triangle and 2 rects
Another one: everything else: poster image, video, and 2 rects to display progress, and play button

So Play group is nested into 'main' group

[asturur]

the 2 groups are grouped togheter?

[solomax]

Yep, Main group, contains 'Play' group

[solomax]

I can try to 'clean up' the fiddle. The issue can easily be debugged if you put breakpoint into 'mouseup' handler

Surprisingly 'mousedown' seems to be not affected

[asturur]

i found the problem, i just needed the situation to write a test so that the bug can be catched in future

…

On Sep 8, 2017 10:03 AM, "Maxim Solodovnik" ***@***.***> wrote: I can try to 'clean up' the fiddle. The issue can easily be debugged if you put breakpoint into 'mouseup' handler Surprisingly 'mousedown' seems to be not affected — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4296 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABI4QPlr6IGstVfZjWP9JDrrqVMI_QwHks5sgPS4gaJpZM4PQube> .

[solomax]

I'll try to simplify the fiddle and will let you know

[asturur]

is ok i have the info i need.

[solomax]

OK, Thanks!
Please let me know if there is anything I can do

[asturur]

Well to be honest 100% i did not try the solution. but i m confident it works, the test pass.

[solomax]

I have applied your patch locally, seems to work as expected
Thanks a lot!

[solomax]

Was able to build it :)
Thanks a lot for the quick fix!