-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images aren't resizable in IE8 #5
Comments
fabric.js looks really awesome, but not being able to scale or move images in IE7/8 would be pretty much a show stopper for me. Are there any forks or work–arounds existing which tackle this problem? Cheers! |
Not that I know of :( The problem is that fabric relies on excanvas in non-canvas-capable (but VML-capable) browsers like IE7 or 8. Last time I looked into this issue, I couldn't figure out why excanvas doesn't render image properly (after rotation)/. IE9 works as expected, but I understand that IE7/8 support for this could be very crucial. I'll look into it once again, asap. |
awsome |
Is anyone working on this? |
IIRC, I ran into excanvas limitation last time I looked at it. Does On Thu, Nov 8, 2012 at 5:59 PM, Fotis Adamakis [email protected]:
|
why we not redirect user to install google chrome frame for IE, iam so stressed , IE very sensitive like a girl haha |
Any developments on this issue? |
Just tried it using IE7 and IE8 modes of IE9, transformations worked okay. |
As far as I know, the bug is still in excanvas (you can see a link to it and more in https://github.com/kangax/fabric.js/wiki/Fabric-limitations-in-oldIE) There's an unofficial patch that supposedly fixes it but I haven't had a chance to try it yet. If anyone can try it and confirm, that would be great! |
Tried the tests in http://dev.sencha.com/playpen/tm/excanvas-patch/, they pass fine on real IE6 (XP). |
@raichu Thanks for looking into it. I applied the patch to excanvas.js that we had under /lib. Surprisingly, it applied clean. I then checked in IE8 mode under IE10 (in virtual machine) and while I see that image sizes now seem to be respected (yay!), the position still seems to be defunct. I can move bounding box, but the actual image is always rendered in top/left corner. You should be able to see this on fabricjs.com, which I updated with newly-patched excanvas. |
Wow, I never thought it would be default on fabricjs.com so quickly --thanks!! I just fired up the patterns and controls demos (real IE6, under XP), and everything works just fine. I can move, rotate and scale the image without problems (except I'm getting the wrong mouse cursor when scaling while keeping the aspect-ratio at the corners, but it probably doesn't have anything to do with the canvas). Maybe the IE8 mode isn't really realiable? |
Yeah, IE8 mode could definitely be the problem. I'm glad to hear it's On Sun, Mar 31, 2013 at 7:01 PM, raichu [email protected] wrote:
|
Works even better on IE7 (XP): the mouse cursor is the correct one. I'll try to test it on IE8 as well, but I think it'll all be okay. |
Cool. I'm closing this then. If anyone else can confirm, that would be great. |
Now, if we could make other stuff work :) |
I tested it on real IE8 (Win 7) and it worked (rotate, move, scale). |
That's great, thanks for confirming @Kienz! |
* Fix IE rendering of SVG as overlay image * Fix IE rendering of SVG as overlay image #2 - Fix coding syntax (CI) * Fix IE rendering of SVG as overlay image #3 - Fix coding syntax (CI) * Fix IE rendering of SVG as overlay image #4 - Moved to method 'loadImageInDom' * Fix IE rendering of SVG as overlay image #5 - Moved some stuff around * Fix IE rendering of SVG as overlay image #6 - Fixed the setTimeout (removed) * Update misc.js
Specifically IE8
The text was updated successfully, but these errors were encountered: