Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lockScalingY=false/lockScalingX=false not working when fabric.Textbox doesn't packaged #5850

Closed
mikab opened this issue Aug 20, 2019 · 1 comment · Fixed by #5896
Closed
Labels
Milestone

Comments

@mikab
Copy link

mikab commented Aug 20, 2019

Version

3.2.0

Test Case

https://jsfiddle.net/mikabpeng/e9s3tdqo

Information about environment

Chrome 74.0.3729.169

Steps to reproduce

Use a custom build fabric.js exclude fabric.Textbox class
Create a fabric.Rect and set lockScalingY= false, lockScalingX= false
Click the rect to make the rect selected
drag the middle or center control point to zoom the rect

Expected Behavior

The rect zoomed as dragging

Actual Behavior

The rect didn't zoom as dragging. A javascript exception thrown in the background:fabric.3.2.0_without_textbox.js:9685 Uncaught TypeError: Right-hand side of 'instanceof' is not an object
exception

@asturur
Copy link
Member

asturur commented Aug 20, 2019

right.... this should be fixed.
Need to check that the class has been imported/added to the build.

@asturur asturur added the bug label Aug 20, 2019
asturur added a commit that referenced this issue Sep 27, 2019
@asturur asturur added this to the 3.5.1 milestone Nov 18, 2019
asturur added a commit that referenced this issue Nov 18, 2019
thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this issue Nov 18, 2019
ickata pushed a commit to ickata/fabric.js that referenced this issue Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants