Add a bool to force cache clear on next render #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -579,7 +579,6 @@ fabric.util.object.extend(fabric.IText.prototype, /** @lends fabric.IText.protot | |||
|
|
|||
| this._removeExtraneousStyles(); | |||
|
|
|||
| this._clearCache(); | |||
There was a problem hiding this comment.
this gets removed.
Removing char is changing text property so no need to enforce cache clearing.
kangax
added a commit
that referenced
this pull request
May 18, 2015
Add a bool to force cache clear on next render
|
Thanks asturur |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2201 made me found out the bug i was searching for.
Clearing cache is not enough, because dimension of text where not recalculated if cache clearing was not detected by
_shouldClearCache()method.Adding a boolean that force cache clearing solves this problems, also avoids to clear cache too many time for one rendering
closes #2201