-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove activeGroup functionalities from Group, create ActiveSelection class #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
I hope you won't get killed any time soon 😃 In case someone happens to read this, few corrections:
use discardActiveObject
use _discardActiveObject |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pro:
Simplifications:
getActiveObject, setActiveObject, getActiveObjects return an array of selected objects.
getActiveGroup, setActiveGroup are removed.
deactivateAllWithDispatch is removed, use discardActiveGroup.
deactivateAll is removed, use _discardActiveGroup.
Added activeSelection => group, single high level method.
removed all the dancing of
originalHasControls, hasControls
relative to group.removed the weird logic of rendering controls in groups.
built in possibility to cancel a deselect, making onDeselect return true.
possibility to do group => activeSelection
missing:
restoring the lock system, an object locked in the active selection makes the activeselection locked
Cons:
Api changes
everyone confused on what is going on
possible regressions
riot
i eventually get killed