Paint order #4303
Merged
Paint order #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see I have some cleanup to still do on this. |
|
And that requireOwnCache is too strict. |
added 2 commits
September 14, 2017 09:26
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Fabric to respect the paint-order attribute in SVG2 as documented here: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/paint-order
This will both read paint-order from an SVG and output it to an svg from fabric.
Internally fabric will call this
paintFirstas fabric only has stroke or fill to draw first and does not implement the more complicated markers. SettingpaintFirsttofillorstrokewill draw that first and will get drawn over by what is painted second.this did break some tests that were not expecting to see
paintFirstcome out of toObject and I've add 1 tests for loading in an svg with the value, checking the value is set correctly, then exporting to SVG and then also checking for the correct output.