Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toSVG() excludeFromExport for backgroundImage and overlayImage #5075

Merged
merged 10 commits into from
Jul 9, 2018

Conversation

durga598
Copy link
Contributor

@durga598 durga598 commented Jun 27, 2018

added excludeFromExport check for backgroundImage and overlayImage in toSVG(), all other objects excludeFromExport = true working fine.

@durga598 durga598 closed this Jun 27, 2018
@asturur asturur reopened this Jun 27, 2018
@asturur
Copy link
Member

asturur commented Jun 27, 2018

The PR is ok. Do not worry about the commit list, just check that the tab Files Changed is clean.

@asturur
Copy link
Member

asturur commented Jul 6, 2018

Going to merge this, i just need to slim down the test

@asturur asturur merged commit 65a219e into fabricjs:master Jul 9, 2018
@asturur asturur mentioned this pull request Aug 5, 2018
thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this pull request Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants