Fix Circle toSVG method adding an incorrect double quote #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you open a different issue for the angle? we should try to make the angle be calculated as 0 and figure out where the approximation error come from |
|
Also since we do not have tests for this case, otherwise it would have fail, would you add one? |
|
Perfect! |
|
oh there is some linting issue. |
|
Looking at Travis, it seems the issue is in master branch, on your last commit |
|
fixed lint on master, rebuilding this and if is green, merging. |
durga598
pushed a commit
to durga598/fabric.js
that referenced
this pull request
Jul 14, 2018
* Fix Circle toSVG method adding an incorrect double quote * Add tests for Circle.toSVG
Merged
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* Fix Circle toSVG method adding an incorrect double quote * Add tests for Circle.toSVG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also wonder if the condition
if (angle === 0)should be changed.I encountered the double quote even though my circle was "full".
The calculated angle was
1.4210854715202004e-14.The condition could be something like
if (angle < 0.001 && angle > -0.001)?