Added callback in setPatternFill #5101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Pattern constructor taking callback, we can use it.
|
Thank you @durga598 this is good. |
Merged
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* Added callback in setPatternFill As Pattern constructor taking callback, we can use it. * doc changed fabricjs#4555 * jsdoc @link added in setCoords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Pattern constructor taking callback, we can use it.
And
fabric.util.loadImageused if we use url in source, so removed in demo.text.class doc changed #4555
In setCoords() doc, there was a link when to call, added @link to act as a link, jsdoc