Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added requestRenderAllBound #5138

Merged
merged 1 commit into from
Aug 5, 2018
Merged

Added requestRenderAllBound #5138

merged 1 commit into from
Aug 5, 2018

Conversation

durga598
Copy link
Contributor

@durga598 durga598 commented Aug 3, 2018

As requestRenderAllBound is undefined in _initStatic method of fabric.Canvas class initialize method. Here is jsfiddle.

As requestRenderAllBound is undeifned in `_initStatic` method. Here is [jsfiddle](https://jsfiddle.net/durga598/utaodqwm/).
@asturur
Copy link
Member

asturur commented Aug 5, 2018

Hi Durga, i m fine with this change.
I did not see the utility in first place, but at the end it can be useful too if you have multiple callback finishing very near in time.

Just to be clear to whoever read this PR, the bound method are just a typing save utility to avoid putting in callbacks

this.loadSomething(canvas.renderAll.bind(canvas))

that becomes:

this.loadSomething(canvas.renderAllBound)

@asturur asturur merged commit ed50b03 into fabricjs:master Aug 5, 2018
@asturur asturur mentioned this pull request Aug 5, 2018
thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this pull request Nov 18, 2019
As requestRenderAllBound is undeifned in `_initStatic` method. Here is [jsfiddle](https://jsfiddle.net/durga598/utaodqwm/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants