Feature/add href parsing #5156
Merged
Feature/add href parsing #5156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulusSEL/fabric.js into feature/add-href-parsing
…ulusSEL/fabric.js into feature/add-href-parsing
|
This looks good! |
|
it does, but implicitly. It can be removed because ie9 is no more supported and that getById polifyll is no more needed. Would you mind jsut duplicate your test as it is, using xlink:href and changing the title to it? that would make me happy that we locked down the situation of the href parsing |
Merged
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* Add href support for parsing use directives (svg) * Add href support for parsing use directives (svg) * Add href support for parsing use directives (svg) * Fix linting errors * add xlink:href test * Update parser.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issues in parsing SVG2.0
<use />tags as referenced #5155.