various small svg fixes #5424
Merged
various small svg fixes #5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
commented
Dec 9, 2018
| fontSize = parentFontSize = parentAttributes.fontSize || fabric.Text.DEFAULT_SVG_FONT_SIZE; | ||
| if (ownAttributes['font-size']) { | ||
| fontSize = parseUnit(ownAttributes['font-size'], parentFontSize); | ||
| } |
There was a problem hiding this comment.
@rikkarv the idea here is that
- parseUnit should be used always.
- if the current fontSize is specified in EM ( i think is sort of legit ) we must reference the parent fontsize
There was a problem hiding this comment.
ok this is not good needs additional tweaking as per the uploaded test.
There was a problem hiding this comment.
I have already tested your changes and
ownAttributes['font-size'] = fontSize = parseUnit(ownAttributes['font-size'], parentFontSize);
is really doing his job. Now i have fontSize as a number instead of a string and the following maths doesn't break.
Thank you very much for your effort
Merged
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* various small svg fixes * no debugger * fontsize parsing fix - again * added a visual test * use min 9px * added comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5412
close #5414
close #5415
close #5417