-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a different dataUrl #5452
Conversation
Cool! Just curious, how would this differ from the current toDataUrl with multiplier method as far as outputting high res images? |
So current export toDataUrl and generically renders at high res ( like 10k x 10k or 16k x 16k where browser can do it ) are made blurry by the cache system that cannot go higher than a certain limit ( since cache is built for performance rather than exporting images ). Now since clipPath, cache is no more an option. That would invalidate all caches, and recreate them, but give you a clean hi res export. Now you cannot do that anymore if you use clippaths. This is a first change: The other change, that i already developed and i need to adapt to clipPath, is a different render method that will avoid using cache. |
this precise commit is adding a public method, removing a private one, and not changing any output but is saving a renderAll and a canvas resize when used with multiplier. |
and indeed i broke. |
unsure why the function coverage is dropped to 79.31% from 80%. like if 8 functions are not more tested. |
* changed toDataUrl * ok not broken * ok not broken * fix * missed the offscreen
This is the first step to get a better higher resolution render.