Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for when toObjects is called on a canvas with a clipPath #5556

Merged
merged 6 commits into from
Mar 15, 2019
Merged

Fix for when toObjects is called on a canvas with a clipPath #5556

merged 6 commits into from
Mar 15, 2019

Commits on Mar 5, 2019

  1. refactor _toObjectMethod to add clipPath to return canvas object if i… 

    …t exists
    @anthify
    anthify committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    af8ed77 View commit details
    Browse the repository at this point in the history

  2. add JSON.stringify to object comparison to pass deepEquals

    @anthify
    anthify committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    4cc4cf7 View commit details
    Browse the repository at this point in the history

  3. remove trailing space

    @anthify
    anthify committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    8d3abdb View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2019

  1. call _toObjects with clipPath and methodName to retrieve object repre… 

    …sentation of clipPath object, without the klass prototype
    @anthify
    anthify committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    72ed42a View commit details
    Browse the repository at this point in the history

  2. remove redundant JSON.stringify on clipPath object. This was added to… 

    … fix a seemingly unknown issue at the time attributed to the QUnit, but was in fact to do with the clipPath not having _toObject applied to it, thus it keeping the klass prototype, and not a plain JS object
    @anthify
    anthify committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    d43b31b View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. add full object for what clipPath should be in order to test against … 

    …the toObject method of the clipPath
    @anthify
    anthify committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    8fe1c55 View commit details
    Browse the repository at this point in the history