Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix splitByGrapheme selection #5588

Merged
merged 5 commits into from
Mar 24, 2019
Merged

Fix splitByGrapheme selection #5588

merged 5 commits into from
Mar 24, 2019

Conversation

asturur
Copy link
Member

@asturur asturur commented Mar 23, 2019

Add selection offsets to compensate for missing newlines in text.

close #5572

Now selection is good, but text that contains new lines cannot yet be splitted with splitByGrapheme

@asturur
Copy link
Member Author

asturur commented Mar 23, 2019

Needs tests for:

  • _generateStyleMap
  • missingNewLineOffset
  • get2DCursorLocation
  • getDownCursorOffset
  • getUpCursorOffset

@asturur asturur merged commit 35c2c3b into master Mar 24, 2019
@asturur asturur mentioned this pull request May 19, 2019
@asturur asturur deleted the fix-grapheme-split branch May 19, 2019 19:30
thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this pull request Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(textBox)The cursor position of the second line is incorrect after the text is wrapped
1 participant