Consistent return in stopObserving() and fire() methods. #5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistent return in stopObserving() and fire().
|
thanks! |
|
A small test would probably expand line converage a bit and ensure no one breaks it again. |
|
Any chance to add a small test? |
|
i'll add the test and merge |
This was referenced May 19, 2019
Merged
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
Consistent return in stopObserving() and fire().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent return in stopObserving() and fire().
Methods are declared to be chainable and always return this reference, but in some cases return undefined.