Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polygon/Polyline/Path respect points position when initializing outside svg #5668

Merged
merged 9 commits into from
May 6, 2019
Merged

Polygon/Polyline/Path respect points position when initializing outside svg #5668

merged 9 commits into from
May 6, 2019

Conversation

asturur
Copy link
Member

@asturur asturur commented May 4, 2019 •
edited
Loading

Change the way polygon/polyline/path guess left,top from constructor.

breaking changes:

  • top and left are always output in the JSON dataless mode
  • top and left for polygon/polyline/path are calculated accounting for strokeWidth and origins so that at initial creation postion of points in constructor is respected.
  • one privated method of path has been renamed for code reusing.

close #5636

@asturur asturur merged commit f77e485 into master May 6, 2019
@asturur asturur deleted the polygon-parse branch May 19, 2019 19:29
@asturur asturur mentioned this pull request May 19, 2019
Merged
thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this pull request Nov 18, 2019
@asturur
Polygon/Polyline/Path respect points position when initializing outsi…
f44e8f4 
…de svg (fabricjs#5668)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stroke is offset from fill.
1 participant
@asturur