Fix parsing number values using scientific notation w/ a capital E. #5731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i m ok with this PR. |
|
thanks! |
Merged
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
…abricjs#5731) * Test parsing number values using scientific notation w/ a capital E. * Fix parsing number values using scientific notation w/ a capital E.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes parsing numbers like
1.2E3→ 1200 infabric.reNum.Per https://www.w3.org/TR/css-syntax-3/#number-token-diagram, either lowercase
eor uppercaseEcan be used in scientific notation numbers. (That page is called "CSS Syntax" but the SVG spec at https://www.w3.org/TR/SVG/types.html#InterfaceSVGNumber delegates to that section of the CSS spec.)I updated the existing tests for parsing
matrixandpoints.pointsalready worked fine because it usesparseFloatand notfabric.reNum, but thematrixtest failed before fixing the regular expression.