Trigger onChange and onComplete with the right values

[asturur]

Close #5700

Trigger onChange and onComplete with values as accurate as possible.

[idelsink]

Would this change not fall under the 'incompatible API changes' section of semver? And this should cause the version to not be 3.4.0 but 4.x.x?

[asturur]

the difference is minimal.
You get the arguments on onComplete, exactly as you would get on onComplete when called by onAbort.
You get the onChange arguments capped at max value if the time is bigger than finish time.

Did you encounter a breaking change?

[idelsink]

I did encounter a breaking change but that was mostly my 'incompetence' (for lack of a better word) :-) for depending on the undefined value of the onComplete function argument. I wanted to know if another animation was running in the onComplete method so that I can hide something when it was not moving. I reworked it by using the onChange percentage and the abort method. This seems to work as expected now.

[asturur]

the fabricjs animation system is not that great. sometimes i wonder if i should remove and just get some examples with other animation libraries.

[idelsink]

You mean like incorporate some external library or take inspiration from another library? I do think that as a whole animation support is a real strong feature of FabricJS

[asturur]

i was meaning that any animation library can animate a fabricjs object.
like tween.js or others ( that i do not know of ).
I m not sure it make sense to have our animation code.