Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-5984 Avoid enter editing in non selectable object #5989

Merged
merged 5 commits into from
Nov 22, 2019
Merged

ISSUE-5984 Avoid enter editing in non selectable object #5989

merged 5 commits into from
Nov 22, 2019

Conversation

asturur
Copy link
Member

@asturur asturur commented Nov 20, 2019

close #5984

@dkorobeinikov
Copy link

Isn't this.selected = this === this.canvas._activeObject better? :)

@asturur
Copy link
Member Author

asturur commented Nov 20, 2019

well is nicer and equally readable. I'll take it.

@asturur
Copy link
Member Author

asturur commented Nov 21, 2019

I also added separation of 2 handlers in this PR and i will provide testing for them, they seem untested.

@asturur asturur merged commit 557b44c into master Nov 22, 2019
@asturur asturur mentioned this pull request Dec 28, 2019
Merged
@asturur asturur deleted the ISSUE-5984-editable-textbox branch January 15, 2020 13:48
ickata pushed a commit to ickata/fabric.js that referenced this pull request Jul 27, 2021
@asturur
ISSUE-5984 Avoid enter editing in non selectable object (fabricjs#5989)
6764a0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

group objects can not be edited
2 participants
@asturur @dkorobeinikov