Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-6072 Fix image index overrun and add test for js convolution filter #6088

Merged
merged 1 commit into from
Jan 12, 2020

Conversation

rfinck
Copy link
Contributor

@rfinck rfinck commented Jan 11, 2020

Previously, the convolution filter tried to extend beyond the boundaries of the image, which would attempt to add undefined to the last row and column of pixels and thus throw off the results.

This is the js half of #6072 ; the gl part is split out since it includes bigger changes to the testing setup.

@asturur
Copy link
Member

asturur commented Jan 12, 2020

this is good as it is.
I wonder if i should add a test suite of filters running on images, and compare results.

@asturur asturur merged commit f8e4529 into fabricjs:master Jan 12, 2020
@asturur asturur mentioned this pull request Jan 17, 2020
ickata pushed a commit to ickata/fabric.js that referenced this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants