ISSUE-6014 ISSUE-6077 support percentage gradient on text #6090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6014
close #6077
I give up in supporting certain features for gradients with text and trying to support everything with the same codepath.
Sadly the text rendering is so much different that it does not make sense.
Those changes keep the fabric rendering behaves a bit better but removes completely support for gradientTransform or patternTransform for text, they were not working anyway because they were just transforming the text and not the gradient or the pattern.
I plan to reintroduce them later with some workaround, following what i did for transformed gradients on stroke.