Add support for empty <style/> tags #6169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to me. |
|
Sure thing. Done! |
|
sorry could i ask you a test for loadSVGFromString that will keep this feature working from regression? A unit test should be enough. sorry for not asking before |
|
No problem at all. I've just pushed the changes. I added a unit test for the Please let me know if you indeed want me to a test case for Thanks! |
|
Sorry, the test failing in Chrome and Firefox; works fine on Node though. I'd appreciate if you could tell me how to see the stacktrace of the failing test. |
asturur
reviewed
Feb 27, 2020
|
@asturur done. The CI pipeline is now green :-) |
|
perfect! less code and is functional. |
|
Thank you 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.